DynamoRIO / DynamoRIO/dynamorio

Build zlib from submodule to make cross-compilation easier

Open
#7,420 1 comment 0 reactions 0 assignees View on GitHub
Component-Build
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

The switch to elfutils (#5926, PR #6534) added a requirement to link drsyms with zlib.
That makes it painful to test cross-compilation:
```
CMake Error at ext/drsyms/CMakeLists.txt:247 (message):
zlib not found but required to build drsyms_static on Linux
```
Our GA workflows jump through hoops to get zlib and other libs; for local dev use though it would be nice to not have to do any of that, some of which is really not easy if not on an Ubuntu machine where the exact commands in our .yml files can work.

We have a submodule third_party/zlib and presumably could build our own zlib. If we make it PIC and static and redirect malloc it would also help avoid private library needs: xref #5437 and #7312.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.