DynamoRIO / DynamoRIO/dynamorio

aslr_module_get_times and ReOpenFile support

Open
#7,106 2 comments 0 reactions 0 assignees View on GitHub
help wanted OpSys-Windows
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

- **Is your feature request related to a problem? Please describe.**

The aslr_module_get_times function has multiple issues with file handles per these comments:

https://github.com/DynamoRIO/dynamorio/blob/b0237d21570b92a7d11a2b7a3edf4d25c5c0e1c8/core/win32/aslr.c#L4475-L4478

https://github.com/DynamoRIO/dynamorio/blob/b0237d21570b92a7d11a2b7a3edf4d25c5c0e1c8/core/win32/aslr.c#L4516-L4519

- **Describe the solution you'd like**

Add support for the [ReOpenFile function](https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-reopenfile) since it fixes both issues including cases where handles are duplicated using DuplicateHandle. The function is available on Vista and above.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.