DynamoRIO / DynamoRIO/dynamorio

Cleanup: define asm SYSNUM_REG for all arch

Open
#6,027 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

Reported by @shiptux in https://github.com/DynamoRIO/dynamorio/pull/6014#issuecomment-1533203462:

The asm SYSNUM_REG constant is defined too broadly at https://github.com/DynamoRIO/dynamorio/blob/6cb94a8ad63892bf8c3aca4280a5ef512c22a27a/core/arch/asm_defines.asm#L163. It should be defined only for AArch64.

Further, we should define SYSNUM_REG for all envs and refactor existing asm code to use it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.