DynamoRIO / DynamoRIO/dynamorio

AArch64 codec.py fallthrough redundancy

Open
#5,921 0 comments 0 reactions 0 assignees View on GitHub
Component-IR OpSys-AArch64 OpSys-Linux Priority-Low
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 18h
Merged PRs (30d)
30

Description

https://github.com/DynamoRIO/dynamorio/pull/5918 exposed the redundancy in some parts of handling encoding conflicts from `codec*.txt` definitions when generating decode/encode logic. We should remove this code from codec.py.

Contributor guide

Open the contributing guide

Research direction

Review PR #5918 and then inspect codec.py alongside the codec*.txt definitions to identify the redundant fallthrough handling for encoding conflicts. Remove only the duplicated logic exposed by that comparison and verify the codec generation paths still produce the expected decode/encode logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.