DynamoRIO / DynamoRIO/dynamorio

Cleanup: Make C++ constant style consistent and remove CONSTEXPR define

Open
#5,857 1 comment 0 reactions 0 assignees View on GitHub
Component-DrMemtrace Maintainability
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

We have two cleanup issues related to C++ constants:

1. Now that do not support VS2013 and have C++11 everywhere we can remove this in clients/drcachesim/common/utils.h:
```
/* TODO(i#2924): Remove this and others like it once we stop supporting VS2013. */
#if defined(WINDOWS) && _MSC_VER < 1900
# define CONSTEXPR const /* 'constexpr' not supported */
#else
# define CONSTEXPR constexpr
#endif
```

2. We should make the constant variable names consistent in drcachesim. The official style from https://dynamorio.org/page_code_style.html#autotoc_md122 is to use all caps, yet a number of files are using kCamelCase.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.