DynamoRIO / DynamoRIO/dynamorio

rt_sigprocmask not failing for bad address

Open
#5,254 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

DR's handling of `rt_sigprocmask` doesn't fail even if a bad address is passed. `handle_sigprocmask` indeed checks whether the passed address is valid: https://github.com/DynamoRIO/dynamorio/blob/223213a2f254640cd1433a48cf0bebd20f828274/core/unix/signal.c#L2306, but it returns success anyway: https://github.com/DynamoRIO/dynamorio/blob/223213a2f254640cd1433a48cf0bebd20f828274/core/unix/os.c#L7349. This is causing an assertion to fail in a proprietary app.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.