DynamoRIO / DynamoRIO/dynamorio

Incorrect decision-making about 32/64-bit arm

Open
#5,204 2 comments 0 reactions 0 assignees View on GitHub
Component-Build help wanted OpSys-AArch64
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

CMAKE_SYSTEM_PROCESSOR sometimes reports "arm64" (or similar e.g. "arm64-v8a") instead of "aarch64" as you are expecting here. For example, this happens for GCC on macOS. This results in CMake incorrectly trying to build for 32-bit arm, flagging "-mthumb" as a nonsense flag on those systems.

https://github.com/DynamoRIO/dynamorio/blob/a7737a1aaa86348bcff14e1846275fcbb0810abd/CMakeLists.txt#L214

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.