DynamoRIO / DynamoRIO/dynamorio

Move annotation handling to a client?

Open
#5,160 0 comments 0 reactions 0 assignees View on GitHub
Type-Feature
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

For #4128 we want drreg to know about all clean calls, yet annotation handler clean calls are inserted during mangling and are thus invisible to clients. The solution there for now is for drreg to look for the DR_NOTE_ANNOTATION label that is added in the app2app phase.

We could move just the clean call insertion to a client in the insertion phase, or try to move the annotation insruction sequence identification: but that may be harder to move.

Alternatively, we could collapse drmgr into the core, and then move the handler clean call to the drmgr insertion phase.

EIther approach would eliminate the drreg special-casing of annotation clean calls, and make them visible to instru2instru and other client actions.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.