DynamoRIO / DynamoRIO/dynamorio
Consider removing non-fetched instrs for repstr
Open
Component-DrMemtrace
- Dominant language
- C
- Stars
- 3.2k
- Forks
- 629
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
Xref #2051 and discussion on PR #4912: https://github.com/DynamoRIO/dynamorio/pull/4912#discussion_r633888366
We should consider removing non-fetched instrs for repstr. Today, if the string loop is executed N times, we'll have the `rep stringop` instr N times in the instr stream. The last N-1 instances are marked as `TRACE_TYPE_INSTR_NO_FETCH` so that cache simulators can choose to ignore these duplicate entries.
The thinking today is that maybe core simulators also don't need these duplicate instrs, and we should just have only one single instr entry and then multiple memref entries based on loop count.
Contributor guide
Assessment
This issue has not been assessed yet.