DynamoRIO / DynamoRIO/dynamorio

AArch64 decoder: Add all condition code-touching instructions

Open
#4,849 2 comments 0 reactions 1 assignee Claimed by @MDevereau View on GitHub
Component-IR Google-Affecting OpSys-AArch64 Priority-High
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

Splitting sub-pieces off from the master issue #2626 on finishing the AArch64 decoder. This piece covers ensuring that all instructions that either read or write the condition codes (NZCVQGE) are fully decoded and encoded. Xref the instruction lists here: https://github.com/DynamoRIO/dynamorio/issues/2626#issuecomment-771605153. Xref how missing cases here caused hard-to-debug problems in #4687 and the workaround we put in place which assumes all unknown opcodes both read and write the codes, which adds overhead. We would like to remove the workaround once we have confidence that all the cases are handled.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.