DynamoRIO / DynamoRIO/dynamorio

Add runtime option to disable start/stop API and annotations and then remove the ifdefs

Open
#4,819 2 comments 0 reactions 0 assignees View on GitHub
Maintainability Type-Feature
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

For running untrusted applications, it might be nice to disable all cases where DR listens to the app for what to do: the start/stop API and annotations.

Today we have ifdefs for both of those: but we'd like to remove the DR_APP_EXPORTS define (xref #2971), and the ANNOTATIONS define for that matter once it's ported to AArchXX. Plus it is harder to maintain a separate build.

This option proposes adding a runtime option to disable these features and adding a test to the CI for this option. I think the overhead of checking the option in the inner interp loop will be worth the code cleanliness and maintenance gain?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.