DynamoRIO / DynamoRIO/dynamorio

TLB simulator fails to add tag,pid pair lookup to parent methods

Open
#4,816 0 comments 0 reactions 0 assignees View on GitHub
Bug-ToolFail
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

For #1738 I'm adding a hashtable to speed up cache tag location for high-associativity caches. Looking at the TLB simulator to see how this change impacts it: it seems broken today, since it imposes the pair of tag,pid as the new lookup key, yet only overrides simulator_t::request! It seems like invalidate(), contains_tag(), and propagate_eviction() are all just broken for the TLB simulator since they only look up the tag?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.