DynamoRIO / DynamoRIO/dynamorio

[ARM] Function pointer comparisons with app pc are not all converting LSB

Open
#4,720 1 comment 0 reactions 0 assignees View on GitHub
OpSys-ARM
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

I just hit a detach bug on ARM where it compares the app pc of 0x33288 to the function pointer for dr_app_stop_and_cleanup 0x33289: the latter is decorated with the LSB for Thumb while the former is normalized for decoding.
```
is_stopping_point: pc=0x00033288 vs 0x00033289
```

I suspect there are other instances like this so I'm filing this to audit the code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.