DynamoRIO / DynamoRIO/dynamorio

codereview.cmake uses upload.py when ~/.codereview_upload_cookies is expired

Open
#459 6 comments 0 reactions 0 assignees View on GitHub
Migrated Priority-Low
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 18h
Merged PRs (30d)
30

Description

_From [reid.kle...@gmail.com](https://code.google.com/u/108532745084733145449/) on May 22, 2011 14:07:58_

The cookies saved by upload.py are only cached for about a day (for me at least), so every time I run codereview.cmake, I have to:
1. Delete the cookies file to avoid hanging codereview.cmake.
2. Run upload.py manually if I want to get the patch on codereview.appspot.com.

It's quite a minor issue but I thought I should mention it.

_Original issue: http://code.google.com/p/dynamorio/issues/detail?id=459_

Contributor guide

Open the contributing guide

Research direction

Start by inspecting codereview.cmake and upload.py, then reproduce the workflow with an expired ~/.codereview_upload_cookies file. Check how codereview.cmake invokes upload.py and how expiry is handled; done means the command no longer hangs and can upload the patch without manual cookie deletion or a separate upload.py run.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.