DynamoRIO / DynamoRIO/dynamorio

x87 floating point immediates should be double precision

Open
#4,488 1 comment 0 reactions 0 assignees View on GitHub
Component-IR
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

DR's decoder uses single-precision floats for the x87 immediates from instructions like `fldl2t`. However, these instructions push double extended-precision format values for the 80-bit x87. It seems best for DR to represent them as `double` rather than `float`. (I don't know that it's worth trying to use `long double` or something for a 10-byte format where supported.)

Xref #4408 where for AArch64 we are adding `double` to `opnd_t`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.