DynamoRIO / DynamoRIO/dynamorio

Absolute and relative operands on AArch64: disallow?

Open
#4,260 17 comments 0 reactions 0 assignees View on GitHub
OpSys-AArch64
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

opnd_is_memory_ref() should check for absolute addr not only for X86_64 but for X64 overall.

https://github.com/DynamoRIO/dynamorio/blob/4f9b46023f05c1cfb756e0c61085715a0126b657/core/arch/opnd_shared.c#L1002

opnd_create_far_abs_addr() creates relative opnd but still assigns the ABS_ADDR_kind flag to the opnd. Hence, if this function is called on aarch64, opnd_is_memory_ref() will incorrectly return false.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.