DynamoRIO / DynamoRIO/dynamorio

Set a single param toggle to the work-around used to deal with faulty resets on ARM

Open
#3,912 1 comment 0 reactions 0 assignees View on GitHub
good first issue Maintainability OpSys-ARM
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

Due to #1674, optionsx.h has a series of IF_X86_ELSE work-arounds in order to turn off reset parameters on ARM. Having so many IF_X86_ELSE is not necessary, as all these parameters should be toggled via the main reset param, namely -enable_reset. This issue covers the removal of these IF_X86_ELSE.

An example of such an unneeded IF_X86_ELSE is shown below:

```
OPTION_DEFAULT(uint, reset_at_vmm_percent_free_limit,
IF_X86_ELSE(10, 0), /* i#1674: re-enable on ARM once xl8 bugs are fixed */

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.