DynamoRIO / DynamoRIO/dynamorio
Package compatibility checks seem broken.
- Dominant language
- C
- Stars
- 3.2k
- Forks
- 629
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
The logic in make/DynamoRIOConfigVersion.cmake.in doens't seem to apply to every case. For example as of right now with pull request https://github.com/DynamoRIO/dynamorio/pull/3497/, the logic in version checks has specific if/else for minor version number 4 and 0, see
```
elseif ("${PACKAGE_FIND_VERSION_MINOR}" LESS @VERSION_NUMBER_MINOR@)
if ("${PACKAGE_FIND_VERSION_MAJOR}" EQUAL 4 AND
"${PACKAGE_FIND_VERSION_MINOR}" EQUAL 0)
# 4.1 is incompatible with 4.0
```
We should put in something more generally applicable. For example with pull request above, a check for 7.1 will return compatibility, while 7.90 is really not.
Contributor guide
Assessment
This issue has not been assessed yet.