DynamoRIO / DynamoRIO/dynamorio

Add calling convention macros to asm_defines to be used in asm functions

Open
#3,289 0 comments 0 reactions 0 assignees View on GitHub
Component-Tests OpSys-Linux OpSys-UNIX OpSys-Windows OpSys-x64 OpSys-x86 Type-Feature
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 18h
Merged PRs (30d)
30

Description

Instead of push/pop #if/#else by architecture and system in asm code, provide proper PUSH_CALLEE_SAVED_REGS/POP_CALLEE_SAVED_REGS macros that can be used instead.

Contributor guide

Open the contributing guide

Research direction

Start by locating asm_defines and the assembly functions that currently duplicate architecture- and system-specific push/pop conditionals. Define the requested callee-saved-register macros there, replace the duplicated conditionals in the affected assembly functions, and verify that the relevant assembly builds still work across the supported architectures and systems.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.