DynamoRIO / DynamoRIO/dynamorio

obtain Windows syscall numbers offline

Open
#2,713 0 comments 0 reactions 0 assignees View on GitHub
help wanted Maintainability OpSys-Windows
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 18h
Merged PRs (30d)
30

Description

With the frequent major win10 updates, adding new tables to
core/win32/syscallx.h and core/win32/syscall.c is getting tedious and taking up
space. Should we stop adding the win10 updates here and give up on our table of
numbers, relying on reading the wrappers (#1598 changed DR to work purely on
wrapper-obtained numbers)? We'd lose robustness vs hooks, and clients like
Dr. Memory who have to distinguish win10 versions would have to do their own
versioning. I guess we could still have DR_WINDOWS_VERSION_xx and not have
corresponding tables here. Or we could go the planned Dr. Memory route
(https://github.com/DynamoRIO/drmemory/issues/1848) and store these numbers in a
separate file that is updated via a separate standalone utility run once by the
user.

Xref #1854

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.