DynamoRIO / DynamoRIO/dynamorio

eliminate variable-length array in dr_frontend_unix.c

Open
#2,310 0 comments 0 reactions 0 assignees View on GitHub
Component-Build Priority-Low
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

Some build environments may want to link drfrontendlib into a C++ app by directly compiling the frontendlib sources, and may use -Wvla to build dr_frontend_unix.c, which then hits:

libutil/dr_frontend_unix.c:135:13: error: variable length array used [-Werror,-Wvla]
char tmp[full_path_size];

That's legal in C99 but not in C++.

Not high priority since this does not affect officially supported build actions but we may want to clean it up for maximum compatibility.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.