DynamoRIO / DynamoRIO/dynamorio

git_review.sh should fault too-old git instead of using bogus log message

Open
#1,916 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

Older versions of git don't understand the %B format: "git log -n 1 --format=%B" will output "%B". git_review.sh could test for this ("$log" = "%B") and fault, rather than proceeding to commit with a bogus log message containing just %B.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.