DynamoRIO / DynamoRIO/dynamorio

fix failing tests in debug build long suite

Open
#1,807 49 comments 0 reactions 0 assignees View on GitHub
Bug-AppFail Bug-Assert Component-Tests help wanted
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 18h
Merged PRs (30d)
30

Description

Xref #1793. There are many, many tests failing in the long suite. This issue covers fixing them (or removing sets of runs if we decide not to support them anymore) and getting the long suite clean so we can re-enable it.

```
debug-internal-32: 2022 tests passed, **** 81 tests failed, of which 15 were flaky: ****
code_api|client.thread
code_api,opt_memory|linux.child-blacklist
code_api,opt_memory|security-common.selfmod => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/security-common.selfmod (26116). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:2999 (is_coarse coarse != NULL) || (!is_coarse coarse == NULL)
code_api,opt_memory|client.drwrap-test
code_api|linux.signest
code_api,opt_speed|linux.persist-use_FLAKY
code_api,opt_speed|client.call-retarget
code_api,opt_speed|client.count-ctis
code_api,opt_speed|client.count-ctis-noopt
code_api,opt_speed|client.syscall
code_api,opt_speed|client.flush
code_api,opt_speed|client.inline
code_api,opt_speed|client.drreg-test
code_api,opt_speed|client.drwrap-test
code_api,opt_speed|client.pcache-use
code_api,opt_speed|sample.bbbuf
code_api,opt_speed|sample.modxfer
code_api,opt_speed|sample.modxfer_app2lib
code_api,opt_speed|sample.instrcalls
code_api,opt_speed|tool.drcov.fib
code_api,thread_private|linux.child-whitelist
code_api,thread_private|linux.child-blacklist
code_api,thread_private|linux.freeze_FLAKY
code_api,thread_private|linux.persist_FLAKY
code_api,thread_private|linux.persist-use_FLAKY
code_api,thread_private|client.syscall => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/client.syscall (28252). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/fragment.c:5648 thread_owns_no_locks(dcontext) || thread_owns_one_lock(dcontext, thread_initexit_lock) || thread_owns_two_locks(dcontext, thread_initexit_lock, all_threads_synch_lock)
code_api,opt_speed|linux.fib-pie
code_api,thread_private|client.thread
code_api,thread_private|client.inline
code_api,thread_private|client.pcache => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/client.pcache (28746). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/options.c:1775 false
code_api,thread_private|client.pcache-use => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/client.pcache (28747). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/options.c:1775 false
code_api,disable_traces|linux.child-whitelist
code_api,disable_traces|linux.child-blacklist
code_api,disable_traces|linux.freeze_FLAKY
code_api,disable_traces|linux.persist-use_FLAKY
code_api,disable_traces|client.pcache-use
code_api,thread_private,disable_traces|linux.child-blacklist
code_api,thread_private,disable_traces|linux.child-whitelist
code_api,thread_private,disable_traces|linux.freeze_FLAKY
code_api,thread_private,disable_traces|linux.persist_FLAKY
code_api,thread_private,disable_traces|linux.persist-use_FLAKY
code_api,thread_private,disable_traces|client.syscall => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/client.syscall (30260). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/fragment.c:5648 thread_owns_no_locks(dcontext) || thread_owns_one_lock(dcontext, thread_initexit_lock) || thread_owns_two_locks(dcontext, thread_initexit_lock, all_threads_synch_lock)
code_api,thread_private,disable_traces|client.thread
code_api,thread_private,disable_traces|client.inline
code_api,thread_private,disable_traces|client.pcache => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/client.pcache (30747). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/options.c:1775 false
code_api,thread_private,disable_traces|client.pcache-use => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/client.pcache (30753). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/options.c:1775 false
code_api,no_early_inject|linux.child-blacklist
code_api,no_early_inject|client.drmgr-test
code_api,no_early_inject|client.pcache-use
code_api,no_early_inject|tool.drcachesim.simple
code_api,no_early_inject|tool.drcachesim.TLB-simple
code_api,no_early_inject|tool.drcachesim.phys
code_api,no_early_inject|tool.drcpusim.mmx
code_api,no_early_inject|tool.drcpusim.sse
code_api,no_early_inject|tool.drcpusim.sse2
code_api,no_early_inject|tool.drcpusim.sse3
code_api,no_early_inject|tool.drcpusim.ssse3
code_api,no_early_inject|tool.drcpusim.sse41
code_api,no_early_inject|tool.drcpusim.sse42
code_api,stack_size,loglevel|client.thread
code_api,sysenter_is_int80|linux.child-blacklist
code_api,sysenter_is_int80|linux.child-whitelist
code_api,sysenter_is_int80|linux.persist-use_FLAKY
code_api,thread_private,tracedump_binary|common.broadfun => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.broadfun (537). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.fib => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.fib (546). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.decode-bad => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.decode-bad (548). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.eflags => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.eflags (550). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.floatpc => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.floatpc (552). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.floatpc_xl8all => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.floatpc (557). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.getretaddr => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.getretaddr (558). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.nativeexec_exe => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.nativeexec (565). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.nativeexec_bindnow => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.nativeexec (567). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.segfault => Application /work/dr/nightly/run/build_debug-internal-32/suite/tests/bin/common.segfault (579). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
checklevel|linux.child-whitelist
checklevel|pthreads.ptsig_FLAKY
checklevel|linux.persist_FLAKY
code_api,sysenter_is_int80|linux.signest
checklevel|api.startstop_FLAKY
finite_shared_trace_cache,cache_shared_trace_regen|linux.child-whitelist
finite_shared_bb_cache,cache_shared_bb_regen|linux.persist_FLAKY
finite_shared_trace_cache,cache_shared_trace_regen|linux.persist-use_FLAKY
```

```
debug-internal-64: 1991 tests passed, **** 68 tests failed, of which 2 were flaky: ****
code_api,opt_memory|linux.child-blacklist
code_api,opt_memory|linux.child-whitelist
code_api,opt_memory|security-common.selfmod-big => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/security-common.selfmod-big (13440). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:2999 (is_coarse coarse != NULL) || (!is_coarse coarse == NULL)
code_api,opt_memory|float_DR => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/security-common.selfmod (13444). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:2999 (is_coarse coarse != NULL) || (!is_coarse coarse == NULL)
code_api,opt_memory|security-common.selfmod => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/security-common.selfmod (13443). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:2999 (is_coarse coarse != NULL) || (!is_coarse coarse == NULL)
code_api,opt_memory|float_vmbase => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/security-common.selfmod (13454). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:2999 (is_coarse coarse != NULL) || (!is_coarse coarse == NULL)
code_api,opt_memory|client.drwrap-test
code_api,opt_speed|client.call-retarget
code_api,opt_speed|client.count-ctis
code_api,opt_speed|client.count-ctis-noopt
code_api,opt_speed|client.syscall
code_api,opt_speed|client.flush
code_api,opt_speed|client.cbr-retarget
code_api,opt_speed|client.inline
code_api,opt_speed|client.drreg-test
code_api,opt_speed|sample.modxfer
code_api,opt_speed|sample.modxfer_app2lib
code_api,opt_speed|sample.instrcalls
code_api,opt_speed|tool.drcov.fib
code_api,thread_private|linux.child-whitelist
code_api,thread_private|client.syscall => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/client.syscall (15506). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/fragment.c:5648 thread_owns_no_locks(dcontext) || thread_owns_one_lock(dcontext, thread_initexit_lock) || thread_owns_two_locks(dcontext, thread_initexit_lock, all_threads_synch_lock)
code_api,thread_private|client.pcache => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/client.pcache (15986). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/options.c:1775 false
code_api,thread_private|client.pcache-use => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/client.pcache (15987). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/options.c:1775 false
code_api,thread_private,disable_traces|client.syscall => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/client.syscall (18399). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/fragment.c:5648 thread_owns_no_locks(dcontext) || thread_owns_one_lock(dcontext, thread_initexit_lock) || thread_owns_two_locks(dcontext, thread_initexit_lock, all_threads_synch_lock)
code_api,thread_private,disable_traces|client.pcache => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/client.pcache (19030). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/options.c:1775 false
code_api,thread_private,disable_traces|client.pcache-use => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/client.pcache (19055). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/options.c:1775 false
code_api,no_early_inject|linux.child-blacklist
code_api,no_early_inject|linux.readlink
code_api,no_early_inject|client.drmgr-test
code_api,no_early_inject|tool.drcachesim.simple
code_api,no_early_inject|tool.drcachesim.TLB-simple
code_api,no_early_inject|tool.drcachesim.phys
code_api,no_early_inject|tool.drcpusim.ssse3
code_api,no_early_inject|tool.drcpusim.sse41
code_api,no_early_inject|tool.drcpusim.sse42
code_api,sysenter_is_int80|linux.child-blacklist
code_api,sysenter_is_int80|linux.child-whitelist
code_api,tracedump_text,tracedump_origins|common.decode-bad => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.decode-bad (21265). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins|common.decode => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.decode (21267). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins|common.broadfun => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.broadfun (21261). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins|common.floatpc_xl8all => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.floatpc (21275). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins|common.getretaddr => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.getretaddr (21277). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins|common.floatpc => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.floatpc (21273). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins|common.eflags => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.eflags (21271). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins,syntax_intel|common.eflags => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.eflags (21304). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins,syntax_intel|common.broadfun => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.broadfun (21296). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins,syntax_intel|common.decode-bad => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.decode-bad (21300). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins,syntax_intel|common.decode => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.decode (21303). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins|common.segfault => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.segfault (21294). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins,syntax_intel|common.floatpc_xl8all => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.floatpc (21308). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins,syntax_intel|common.floatpc => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.floatpc (21306). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,tracedump_text,tracedump_origins,syntax_intel|common.getretaddr => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.getretaddr (21310). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,thread_private,tracedump_binary|common.fib => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.fib (21330). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.broadfun => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.broadfun (21328). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,tracedump_text,tracedump_origins,syntax_intel|common.segfault => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.segfault (21326). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/annotations.c:359 (dcontext) != NULL (dcontext) != GLOBAL_DCONTEXT
code_api,thread_private,tracedump_binary|common.floatpc => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.floatpc (21338). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.eflags => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.eflags (21336). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.floatpc_xl8all => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.floatpc (21340). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.getretaddr => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.getretaddr (21342). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.decode-bad => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.decode-bad (21332). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.nativeexec_retakeover => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.nativeexec (21346). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.decode => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.decode (21334). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.nativeexec_bindnow => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.nativeexec (21350). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.nativeexec_exe => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.nativeexec (21348). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
code_api,thread_private,tracedump_binary|common.segfault => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/common.segfault (21358). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/vmareas.c:824 SHARED_FRAGMENTS_ENABLED()
checklevel|linux.child-whitelist
checklevel|pthreads.pthreads_fork_FLAKY => Application /work/dr/nightly/run/build_debug-internal-64/suite/tests/bin/pthreads.pthreads_fork_FLAKY (21584). Internal Error: DynamoRIO debug check failure: /work/dr/git/src/core/unix/memcache.c:408 found
checklevel|api.startstop_FLAKY
```

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the debug-internal-32 and debug-internal-64 long-suite runs and grouping failures by the reported entry points in src/core/vmareas.c, src/core/fragment.c, and src/core/options.c. Check the listed suite tests and flaky cases to determine which failures need fixes versus removed runs. Done means the long suite is clean and can be re-enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, linux
Domain
build-system, operating-systems, testing-qa
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.