DynamoRIO / DynamoRIO/dynamorio

dr_annotation_calling_convention_t omits "cdecl"

Open
#1,745 0 comments 0 reactions 1 assignee Claimed by @byron-hawkins View on GitHub
Component-API OpSys-Linux OpSys-Windows Priority-Low Usability
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 18h
Merged PRs (30d)
30

Description

Public enum `_dr_annotation_calling_convention_t` currently omits the `cdecl` calling convention, which is a common option on 32-bit linux. For annotation purposes the `stdcall` and `cdecl` calling conventions are equivalent (so the platform is supported), but the `dr_annotation_calling_convention_t` should include a corresponding alias, since developers have no way to know this.

The docs should also be updated to reflect the fact that `stdcall` only exists on Windows, and that `vararg` is an alias of `cdecl` on linux.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.