DynamoRIO / DynamoRIO/dynamorio

Pre-commit test suite rejects diff with trailing space removed

Open
#1,492 5 comments 0 reactions 0 assignees View on GitHub
Migrated Priority-Medium
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

_From [byron.c....@gmail.com](https://code.google.com/u/101184679827294438523/) on August 02, 2014 19:01:31_

There are some trailing spaces in the current code base (for example, instr.h:1979 in r2733 ), and my text editor removes them automatically. This creates a trailing space in the diff, but it is a removal of the trailing space--we want that, right? A minor change to the regex in suite/runsuite.cmake will ignore trailing spaces in lines that are being removed. I could additionally do the same for tabs, so that those can also be progressively removed from the repository.

_Original issue: http://code.google.com/p/dynamorio/issues/detail?id=1492_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.