DynamoRIO / DynamoRIO/dynamorio

Test suite: strange parse errors of core/win32/resources.rc when git is on the path

Open
#1,469 0 comments 0 reactions 0 assignees View on GitHub
Migrated Priority-Low
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

_From [byron.c....@gmail.com](https://code.google.com/u/101184679827294438523/) on July 09, 2014 04:51:43_

In an msys shell with git on the path, the pre-commit test suite fails with build errors while parsing core/win32/resources.rc. The same problem occurs if git is visible in the CMAKE_PROGRAM_PATH, even if no other git-related programs are on the path (i.e., the git executable is individually copied to a separate directory). A workaround is to add an optional PATH variable to cmake's find_program() so it can find the vcs tool on a system where it is not in the cmake program path.

The cause of the parse errors in the .rc file is unknown so far.

_Original issue: http://code.google.com/p/dynamorio/issues/detail?id=1469_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.