DynamoRIO / DynamoRIO/dynamorio

dr_app_cleanup should not kill the other threads

Open
#1,248 0 comments 0 reactions 0 assignees View on GitHub
Component-API Migrated Priority-Medium Type-Feature
Dominant language
C
Stars
3.2k
Forks
629
Avg merge
2d 15h
Merged PRs (30d)
31

Description

_From [bruen...@google.com](https://code.google.com/u/109494838902877177630/) on August 19, 2013 17:43:26_

Currently, dr_app_cleanup will kill all the other threads (in debug build or with a client wanting synchall), and generally assume the process is going down. We should support the app continuing on without DR. Furthermore, the current implementation is unsafe, as killing the other threads without the current thread immediately exiting (like it does under non-start/stop DR) can cause problems where the remaining thread waits on a lock owned by a killed thread.

_Original issue: http://code.google.com/p/dynamorio/issues/detail?id=1248_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.