DynamoRIO / DynamoRIO/drmemory

if -callstack_max_frames truncates suppression to ... drmem then aborts

Open
#678 2 comments 0 reactions 0 assignees View on GitHub
Migrated Priority-Low Usability
Dominant language
C
Stars
2.7k
Forks
290
PR merge metrics
No merged PRs in 30d

Description

_From [bruen...@google.com](https://code.google.com/u/109494838902877177630/) on November 09, 2011 12:54:04_

running chrome with "-suppress
C:\src\chromium\src\tools\valgrind\DrMemory\suppressions.txt" and
-callstack_max_frames 6 (or smaller) => aborts but not a very visible
message (b/c this is chrome.exe launched by ui_tests: direct app launch).

have to go look in global log:

Recorded 32 suppression(s) from default C:\src\drmemory\git\build_drmemory/bin/suppress-default.txt
WARNING: requested max frames truncates suppression callstacks
Malformed suppression:
LEAK
RSAENH.dll!DllUnregisterServer
...
ADVAPI32.dll!CryptAcquireContextA
CRYPT32.dll!CryptEnumOIDFunction
...
CRYPT32.dll!CertFindCertificateInStore

The given suppression ends with '...'
Usage error: Malformed suppression. See the log file for the details. Aborting.

question: if user says "-callstack_max_frames 4" and has some suppressions
longer than 4, today we truncate those suppressions. this can end up with
an illegal suppression (ending with ...) and drmem aborting w/ probably a
confusing error. are there better solutions. should the max frames be
adjusted to be big enough for biggest suppression, ignoring the user's
requested max? should illegal suppression checks be relaxed in presence of short max?

xref issue #672

_Original issue: http://code.google.com/p/drmemory/issues/detail?id=678_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.