DynamoRIO / DynamoRIO/drmemory
Unable to match suppressions against modules with names longer than MAX_MODULE_LEN
- Dominant language
- C
- Stars
- 2.7k
- Forks
- 290
- PR merge metrics
- No merged PRs in 30d
Description
_From [rnk@google.com](https://code.google.com/u/rnk@google.com/) on November 06, 2012 13:42:33_
The problem is that we truncate module names longer than MAX_MODULE_LEN (32 on Windows), which makes suppression matching fail in unexpected ways.
A user might write a suppression like "*.exe!MyFunc" and have it fail for an exe with a long basename, like racecheck_unittest-windows-x86-O0.exe.
Symbolized callstacks aren't long lived (they are printed and then deleted) and un-symbolized callstacks refer to a shared modname_info_t struct, so the memory cost of simply bumping MAX_MODULE_LEN up to MAXIMUM_PATH is probably negligible.
See this comment where we hit this problem originally: https://code.google.com/p/drmemory/issues/detail?id=837#c3
_Original issue: http://code.google.com/p/drmemory/issues/detail?id=1082_
Contributor guide
Assessment
This issue has not been assessed yet.