DynamicsAndNeuralSystems / DynamicsAndNeuralSystems/catch22
The \sigma of pNN40 is a scaling factor or std?
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 498
- Forks
- 79
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
Just noticed from the gitbook, the illustration of the high_fluctuation (i.e., MD_hrv_classic_pnn40) is that "it computes the proportion of difference magnitudes that are greater than 4% of the standard deviation of the time series."
It contradicts its setting in the code base, where it looks more like computing the proportion of difference magnitudes that are greater than 4% of a scaling factor \sigma, where it was chosen to be 1000.
Statements from the original paper of those pnn features might favor the scaling factor possibility more. Thoughts and discussion are welcome!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the GitBook incremental-differences page and the implementation of MD_hrv_classic_pnn40, then compare both descriptions with the original pNN feature paper linked in the issue. Determine which definition is intended and make the documentation and implementation consistent; done means the scaling factor and threshold are unambiguous.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100