DylanMeeus / DylanMeeus/GoAudio

Handle 'JUNK' chunks when reading in wave files

Open
#17 6 comments 0 reactions 1 assignee Claimed by @DylanMeeus View on GitHub
bug
Dominant language
Go
Stars
431
Forks
40
PR merge metrics
No merged PRs in 30d

Description

I was trying to use this module to read in [this wave file](https://freesound.org/people/straget/sounds/424141/) and was having some trouble.

It looks like before the "fmt" chunk, it's possible to have a chunk that begins with "JUNK" that should be skipped.

I believe it's described in this page talking about the "RIFF" format: https://www.daubnet.com/en/file-format-riff
The fix would go around here: https://github.com/DylanMeeus/GoAudio/blob/master/wave/reader.go#L60

Tangentially, there was a similar issue on the tensorflow project: https://github.com/tensorflow/tensorflow/issues/26247

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.