DustinBrett / DustinBrett/daedalOS
Locked aspect ratio windows don't account for title bar in their math
Open
Nobody has claimed this yet.
Windows
- Dominant language
- JavaScript
- Stars
- 13k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Even though react-rnd has some properties which should help, it was not working. Resizing the Doom window will show that eventually bars appear on top/bottom as the resize is not quite happening at the 640x480 ratio, it's more like 640x(480+30).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Doom window's resize handling and its react-rnd configuration. Reproduce the issue by resizing the Doom window, then verify that locked-ratio resizing accounts for the title bar and no longer introduces top or bottom bars around the 640x480 content.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100