DustinBrett / DustinBrett/daedalOS
Can't enter full screen on video player when already in full screen
Open
Nobody has claimed this yet.
Firefox
Safari
Video Player
- Dominant language
- JavaScript
- Stars
- 13k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Like is done with the Picture Viewer, the Video Player needs to handle going in and out of fullscreen differently because Safari & Firefox can't dynamically switch the fullscreenElement (so it seems).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing how the Picture Viewer handles entering and leaving fullscreen with the Video Player behavior described here. Reproduce the issue in Safari and Firefox, then verify that entering and exiting fullscreen works when the player is already fullscreen.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100