Duke-GCB / Duke-GCB/bespin-api

Require size when creating job input files

Open
#162 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
0
Forks
2
PR merge metrics
No merged PRs in 30d

Description

The models for Job Input files default size to 0:

https://github.com/Duke-GCB/bespin-api/blob/58b6e092512e4189f74397fd9ac033677d49dec1/data/models.py#L436

https://github.com/Duke-GCB/bespin-api/blob/58b6e092512e4189f74397fd9ac033677d49dec1/data/models.py#L413

We've seen in https://github.com/Duke-GCB/bespin-cli/issues/13 that leaving this to the default of 0 causes issues.

I propose we remove this model field default and require that every JobInputFile created include a size. I can't think of a case where we wouldn't want that size.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.