[BUG] the favorites view doesn't remember the scroll position (and also lacks a scroll bar)
- Dominant language
- Kotlin
- Stars
- 7.4k
- Forks
- 214
- PR merge metrics
- No merged PRs in 30d
Description
### Guidelines
- [x] I have searched the issue tracker for [open](https://github.com/Droid-ify/client/issues) and [closed](https://github.com/Droid-ify/client/issues?q=is%3Aissue+is%3Aclosed) issues that are related to the bug report I want to file, without success.
- [x] I'm on the [latest](https://github.com/Droid-ify/client/releases/latest) released version.
### What happened
at the "favorites" view the list always scrolls back to the top and even has no scroll bar like the other views.
### Steps to reproduce
1. add quite some favorites to get a list **longer** than one screen
2. scroll down to one of the last favorites
3. open the details for one app
4. go back to all favorites
5. notice that the view starts at the top again
6. then you have to swipe like an idiot, because there is no way to get quickly to a scroll position which is further down the list.
### Expected behavior
when going back to the favorites, the scroll position should be remembered to spare the user quite some annoying scrolling every time he had a look at some app details.
but still a scroll bar like in all other views would be appreciated.
### Screenshots
_No response_
### Device
various
### Android version
various
### Droid-ify version
0.7.7
### Logs
_No response_
### Additional context
the main issue ("loosing scroll position") was already mentioned by @xiou-shian at https://github.com/Droid-ify/client/issues/1373#issuecomment-5359713509.
...and the same bug for the search view(s) had its own ticket: #233
and the scroll bar issue was (partly) solved recently: #311
Contributor guide
Research direction
Start by locating the Kotlin/Android implementation of the favorites view and reproduce the reported navigation flow with a list longer than one screen. Compare the existing behavior with the search-view issue #233 and the scroll-bar work in #311; done means returning from app details preserves the favorites scroll position and provides the expected scroll bar.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100