DonutsNL / DonutsNL/samlsso

Review CronTask.php

Open
#14 1 comment 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
PHP
Stars
52
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Current CronTask implements a deprecated function and references a non-existing method (according to Sonar).

```php
/**
* @deprecated 11.0.0
*/
class QueryExpression extends Glpi\DBAL\QueryExpression
```
The implementation should be aligned with the GLPI11 core. Possibly the task is not functional in the current implementation.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing CronTask.php and the Sonar findings about the deprecated function and non-existing method, then compare its implementation with the GLPI 11 core. Confirm the intended CronTask behavior and update it so the task is functional and aligned with GLPI 11.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.