Domiii / Domiii/dbux

fix so promisified CB's don't accidentally sync

Open
#604 0 comments 0 reactions 1 assignee Claimed by @Domiii View on GitHub
async bug
Dominant language
JavaScript
Stars
171
Forks
13
PR merge metrics
No merged PRs in 30d

Description

* [x] fix promisify links
* Handle the case where the `resolve` call is not in a recorded root (e.g. `setTimeout(resolve)`)
* Fix `async` stack to allow us to query correct root (and `_virtualRootContextId` correspondingly)
* [ ] test w/ `Promise.all*` and `Promise.race/any*` samples
* [ ] test w/ `async-js`, `sequelize#4`
* [ ] e.g. `pushImmediate` trace of errBack has (but should not have) syncPromiseId

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.