Resetting backup retention amount on volume backups to undefined (= unlimited) does not work
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 37.4k
- Forks
- 3k
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 73
Description
To Reproduce
- Create a volume backup for a service (in my case a docker compose)
- Set the "Keep Latest Backups" to a positive non-zero integer and save
- Reload the page
- Edit the volume and clear the "Keep Latest Backup" field and save
- Reload the page
You will see, that the backup limit is still set to the positive integer (can be seen by editing the volume backup)
Current vs. Expected behavior
I expect the retention amount to be reset to no value (undefined) and my backups to be kept indefinetly
Current behavior: The retention amount doesn't get updated when setting it to undefined. (Page reload required to see the actual value).
AFAIK is there no way to turn of the limit once it was set.
Provide environment information
OS: Mac 15.6
Dokploy 0.28.8
Ubuntu VPS
Connection via https
Which area(s) are affected? (Select all that apply)
Application
Are you deploying the applications where Dokploy is installed or on a remote server?
Same server where Dokploy is installed
Additional context
No response
Will you send a PR to fix it?
No
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the volume-backup flow described in the issue: set “Keep Latest Backups,” then clear it and save. Trace the volume backup settings form and its save/update request to see how an undefined value is handled. Done means clearing the field persists after reload and backups are retained indefinitely.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker-compose, typescript
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100