Light/dark template icons, or set a background
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- TypeScript
- Stars
- 37.4k
- Forks
- 3k
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 73
Description
What problem will this feature address?
Some of the templates icons are meant for a light background, or dark background, but depending on what the user is currently using, he will see some and not others,
ways to fix this would be:
- adding both a lightBackgroundIcon and darkBackgroundIcon
- or at least having a way to tell if the icon is supposed to be seen on a lightBackground or a darkBackground, and in this case, if it doesn't match what the user is currently seeing, add a
bg-black rounded-lgorbg-white rounded-lgto the icon view, so that no matter what the user sees, the icon will display on the correct background
Describe the solution you'd like
Described above
Describe alternatives you've considered
Just squint at the icon to try and see it when it's not on the proper background
Additional context
No response
Will you send a PR to implement it?
Yes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating the template-icon rendering and theme/background handling, then determine which proposed approach fits; done means every template icon remains visible against the user's current light or dark background.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100