DjangoPeng / DjangoPeng/word2vec

Fix build errors and warnings

Open
#21 0 comments 0 reactions 0 assignees View on GitHub
auto-migrated Priority-Medium Type-Defect
Dominant language
C
Stars
3
Forks
5
PR merge metrics
No merged PRs in 30d

Description

```
What steps will reproduce the problem?
1. make

What is the expected output? What do you see instead?

clean build

What version of the product are you using? On what operating system?
OSX Yosemite, Apple LLVM version 6.0 (clang-600.0.51) (based on LLVM 3.5svn)

Please provide any additional information below.
Following patch fixes build error (due to malloc.h and warnings due to unused
variables)

Index: compute-accuracy.c
===================================================================
--- compute-accuracy.c (revision 41)
+++ compute-accuracy.c (working copy)
@@ -26,7 +26,7 @@
int main(int argc, char **argv)
{
FILE *f;
- char st1[max_size], st2[max_size], st3[max_size], st4[max_size],
bestw[N][max_size], file_name[max_size], ch;
+ char st1[max_size], st2[max_size], st3[max_size], st4[max_size],
bestw[N][max_size], file_name[max_size];
float dist, len, bestd[N], vec[max_size];
long long words, size, a, b, c, d, b1, b2, b3, threshold = 0;
float *M;
Index: distance.c
===================================================================
--- distance.c (revision 41)
+++ distance.c (working copy)
@@ -28,7 +28,6 @@
char file_name[max_size], st[100][max_size];
float dist, len, bestd[N], vec[max_size];
long long words, size, a, b, c, d, cn, bi[100];
- char ch;
float *M;
char *vocab;
if (argc < 2) {
Index: makefile
===================================================================
--- makefile (revision 41)
+++ makefile (working copy)
@@ -1,6 +1,6 @@
CC = gcc
#Using -Ofast instead of -O3 might result in faster code, but is supported only by newer GCC versions
-CFLAGS = -lm -pthread -O3 -march=native -Wall -funroll-loops -Wno-unused-result
+CFLAGS = -I. -lm -pthread -O3 -march=native -Wall -funroll-loops
-Wno-unused-result

all: word2vec word2phrase distance word-analogy compute-accuracy

@@ -17,4 +17,4 @@
chmod +x *.sh

clean:
- rm -rf word2vec word2phrase distance word-analogy compute-accuracy
\ No newline at end of file
+ rm -rf word2vec word2phrase distance word-analogy compute-accuracy
Index: word-analogy.c
===================================================================
--- word-analogy.c (revision 41)
+++ word-analogy.c (working copy)
@@ -28,7 +28,6 @@
char file_name[max_size], st[100][max_size];
float dist, len, bestd[N], vec[max_size];
long long words, size, a, b, c, d, cn, bi[100];
- char ch;
float *M;
char *vocab;
if (argc < 2) {

```

Original issue reported on code.google.com by `nitingupta910@gmail.com` on 1 Oct 2014 at 5:50

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.