DistributedCollective / DistributedCollective/Sovryn-smart-contracts
Turn the parameter `loanId` as an indexed parameter in the `DepositCollateral` event
Open
@Genysys is already working on this.
Since Nov 14, 2021.
- Dominant language
- JavaScript
- Stars
- 132
- Forks
- 57
- PR merge metrics
- No merged PRs in 30d
Description
Rationale
It simplifies the searching of all collateral added to a specific loan position
Change
from this:
event DepositCollateral(bytes32 loanId, uint256 depositAmount, uint256 rate);
to this:
event DepositCollateral(bytes32 indexed loanId, uint256 depositAmount, uint256 rate);
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.