DistributedCollective / DistributedCollective/Sovryn-smart-contracts

Add a isContract check

Open
#354 0 comments 0 reactions 1 assignee View on GitHub

@smbsp is already working on this.

Since Aug 4, 2021.

meduim priority
Dominant language
JavaScript
Stars
132
Forks
57
PR merge metrics
No merged PRs in 30d

Description

_callOptionalReturn function doesn't have a check to verify if it is a Contract Account or Externally Owned Account. It was on hold due to Contract Size issue. The changes are implemented on top of new Loan Token Logic contracts now.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.