DioxusLabs / DioxusLabs/dioxus

Feature Request: Default window/tray icon from toml

Open
#3,596 0 comments 0 reactions 0 assignees View on GitHub
cli consistency desktop
Dominant language
Rust
Stars
39.1k
Forks
1.9k
Avg merge
4d 10h
Merged PRs (30d)
4

Description

## Feature Request

Currently, when bundling an app with an icon option in the Dioxus.toml bundle, the provided icon will not be set for the window or trayicon (at least not on windows 11) - this is because if no icon is explicitly set, the default dioxus icon will be set instead. Preferably setting the icon in the toml file would also set it for the window and trayicon and only if none is set it would use the default.

Referenced code where default icon is loaded:
https://github.com/DioxusLabs/dioxus/blob/eaf9f80abddd75a6963edf2f48e8e21765146122/packages/desktop/src/webview.rs#L195-L204
https://github.com/DioxusLabs/dioxus/blob/eaf9f80abddd75a6963edf2f48e8e21765146122/packages/desktop/src/trayicon.rs#L37-L45

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.