DioxusLabs / DioxusLabs/dioxus

Feature parity with `tauri build`

Open
#1,437 2 comments 0 reactions 0 assignees View on GitHub
cli
Dominant language
Rust
Stars
39.1k
Forks
1.9k
Avg merge
4d 10h
Merged PRs (30d)
4

Description

## Specific Demand

Currently, dioxus has two building systems, `dx build` and `dx bundle`. While `dx build` is a wrapper around `cargo build` with side-effects, `dx bundle` is a wrapper around `tauri_bundler::bundle::bundle_project`.

What tauri does in `tauri build` is to [Run side-effects in `tauri_build::build()`](https://github.com/tauri-apps/tauri/blob/7db1c31e479b53cd7c5a35181ca678790b6e7058/tooling/cli/templates/app/src-tauri/build.rs), [check the config](https://github.com/tauri-apps/tauri/blob/7db1c31e479b53cd7c5a35181ca678790b6e7058/tooling/cli/src/build.rs#L151), then [bundle_project()](https://github.com/tauri-apps/tauri/blob/7db1c31e479b53cd7c5a35181ca678790b6e7058/tooling/cli/src/build.rs#L151), and [update the build binary/installer after bundling](https://github.com/tauri-apps/tauri/blob/7db1c31e479b53cd7c5a35181ca678790b6e7058/tooling/cli/src/build.rs#L155).

Currently, both two building commands lacks the side-effects from tauri, resulting in webview not properly bundled in the windows installer (see #1321), no app signing, and potentially some mobile/Mac related issues.

## Implement Suggestion

The pre- and post-bundling side-effects should be implemented in either command, or preferrably use the same command for building (see #1387).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.