DimitriGilbert / DimitriGilbert/Formedible

alert and confirm, Claude's favorite

Open
#8 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
47
Forks
2
PR merge metrics
No merged PRs in 30d

Description

CodeRabbit
Replace native confirm() with a non-blocking dialog.

Using the native confirm() function blocks the UI thread and provides a poor user experience. Consider using a modal dialog component instead.

Example implementation:

// Instead of:
if (confirm(`Delete ${page.title}? Fields on this page will be moved to Page 1.`)) {
// deletion logic
}

// Use a confirmation modal:
const [deleteConfirmation, setDeleteConfirmation] = useState<{
show: boolean;
pageId?: number;
title?: string;
}>({ show: false });

// In the button onClick:
onClick={(e) => {
e.stopPropagation();
setDeleteConfirmation({
show: true,
pageId: page.page,
title: page.title
});
}}

// Add a confirmation dialog component
{deleteConfirmation.show && (
{
// deletion logic
setDeleteConfirmation({ show: false });
}}
onCancel={() => setDeleteConfirmation({ show: false })}
/>
)}
Also applies to: 577-581

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.