Dimillian / Dimillian/IceCubesApp
Bug: When approving a follow request, the follow request remains
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 7.1k
- Forks
- 720
- PR merge metrics
- No merged PRs in 30d
Description
When approving a follow request from outside IceCubes, the follow requested notification remains showing (attached image, top and bottom notifications are same person).
The notifications json does not include the follow request after the user has been followed. I haven't looked into it too much, so I don't know if there's anything to look for to update notifications, except maybe checking existing notification follow_requests when a new notification follow is received for same account id.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the notifications JSON is processed for follow_requests and follow notifications after an approval made outside IceCubes. Confirm the same account's follow-request notification is removed once the user is followed, and verify that the remaining notifications still display correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100