Dimillian / Dimillian/IceCubesApp
Bug: Redundant fetching for hashtag navigation
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 7.1k
- Forks
- 720
- PR merge metrics
- No merged PRs in 30d
Description
Environment:
- OS:
iOS 14.4.1 - IceCubesApp version:
Version 1.10.40
Description
Whenever the user navigates to a certain hashtag, if they're already on the view for that hashtag they still will be redirected to the same hashtag, navigating again which allocates more memory for the fetching and can lead to memory bloating. It is also redoing the fetch every time unnecessarily.
Evidence
https://github.com/Dimillian/IceCubesApp/assets/77981728/00a12b0e-5aed-4d03-a792-41602a0fa383
I also ran this using simulator and instruments to see how it is affecting performance and memory.
Related Issues
- Search that this bugs don't already exist before creating it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the iOS simulator by opening a hashtag and selecting that same hashtag again, then trace the hashtag view's navigation and fetching path. Done means the current hashtag does not redirect or trigger another fetch, with the reported memory growth checked using the Instruments workflow mentioned in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100