Dimillian / Dimillian/IceCubesApp

Bug: Respect the instance setting in ShareExtension

Open
#2,072 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Swift
Stars
7.1k
Forks
720
PR merge metrics
No merged PRs in 30d

Description

Environment:

  • OS:
    iOS v17.4.1
  • IceCubesApp version:
    IceCubesApp v1.10.38

Description

This is similar and relevant to https://github.com/Dimillian/IceCubesApp/issues/1943 Basically, my instance support more than 4 images per post, and currently if I launch IceCubesApp and start a post, the media selection window respect the instance's limit.

But if I launch Photo app first and chose images to share, IceCubesApp won't show up in the share sheet. I believe it's due to the hard coded number on https://github.com/Dimillian/IceCubesApp/blob/bb005386dfbfbbecfee306dbdcc71e1ae37908ad/IceCubesShareExtension/Info.plist#L12

I guess there are two options here, 1) I am not sure if we can, but put dynamic number in the plist. 2) remove the restriction in the Info.plist, and check the number of media in the app's code.

Related Issues

similar to https://github.com/Dimillian/IceCubesApp/issues/1943

  • Search that this bugs don't already exist before creating it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with IceCubesShareExtension/Info.plist at L12 and compare its media limit with the instance-aware selection behavior in the app, using issue 1943 as context. Determine how sharing from Photos should handle instances allowing more than four images, then verify that IceCubesApp appears in the share sheet and respects the applicable limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.