Dimillian / Dimillian/IceCubesApp
Bug: PushSubscription.id should be a String
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 7.1k
- Forks
- 720
- PR merge metrics
- No merged PRs in 30d
Description
Description
According to https://docs.joinmastodon.org/entities/WebPushSubscription/#id the PushSubscription ID is cast from an int, but should be a string. I'm implementing a server, and sending back an integer as a string causes IceCubes to not be able to set subscription options.
Related Issues
- Search that this bugs don't already exist before creating it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the PushSubscription model and the code that decodes the Mastodon WebPushSubscription entity. Verify the id representation against the linked Mastodon API documentation and reproduce the IceCubes subscription-options failure if possible. Done means the id is handled as a String and the relevant decoding or subscription behavior works without regression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api, mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100