Dimillian / Dimillian/IceCubesApp

Bug: Messages tab functionality broken after restoring connection

Open
#2,045 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Swift
Stars
7.1k
Forks
720
PR merge metrics
No merged PRs in 30d

Description

Environment:

  • OS: iOS 17.4.1
  • IceCubesApp version: IceCubesApp v1.10.35

Description

When navigating to the 'Messages' tab while the app is without connection a message showing an error has occurred appears. However, after re-establishing connection in the device the messages continues to be displayed on the screen. I believe the error has to do with the state management of the isError variable here, it should be reset to false once the operation completes successfully.

Related Issues

  • Search that this bugs don't already exist before creating it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading Packages/Conversations/Sources/Conversations/List/ConversationsListViewModel.swift, especially the isError state referenced in the issue. Reproduce the offline-to-online flow from the Messages tab and verify that, after the connection is restored and the operation succeeds, the error message is no longer displayed.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.